Skip to content

[Validator] Remove deprecated Expression methods #61104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vinceAmstoutz
Copy link

Q A
Branch? 8.0
Bug fix? no
New feature? yes
Deprecations? no
Issues --
License MIT

Remove deprecated methods in Expression constraint.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@alexandre-daubois alexandre-daubois added the BC Layer removal Used to track BC layer removals before a major release label Jul 11, 2025
@vinceAmstoutz vinceAmstoutz force-pushed the feat/remove-validator-expression-constraint-bc-break branch 3 times, most recently from 832d509 to 44247b0 Compare July 11, 2025 14:02
@vinceAmstoutz vinceAmstoutz force-pushed the feat/remove-validator-expression-constraint-bc-break branch from 44247b0 to b9a3e78 Compare July 11, 2025 14:09
@xabbuh
Copy link
Member

xabbuh commented Jul 11, 2025

see #61063 where I am doing that for all constraint classes

@vinceAmstoutz vinceAmstoutz deleted the feat/remove-validator-expression-constraint-bc-break branch July 12, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Layer removal Used to track BC layer removals before a major release Feature Status: Needs Review Validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy