-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[HttpKernel] Update phpdoc description #61188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 7.4 ? |
a4d9810
to
b5cdeb7
Compare
Updated |
xabbuh
approved these changes
Jul 22, 2025
xabbuh
reviewed
Jul 22, 2025
@@ -113,7 +113,7 @@ public function getStartTime(): float; | |||
/** | |||
* Gets the cache directory. | |||
* | |||
* Since Symfony 5.2, the cache directory should be used for caches that are written at runtime. | |||
* This directory should be used for caches that are written at runtime. | |||
* For caches and artifacts that can be warmed at compile-time and deployed as read-only, | |||
* use the new "build directory" returned by the {@see getBuildDir()} method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* use the new "build directory" returned by the {@see getBuildDir()} method. | |
* use the "build directory" returned by the {@see getBuildDir()} method. |
Maybe?
b5cdeb7
to
f8719e7
Compare
Thank you @alamirault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the same wording as
getBuildDir
method