[Messenger] Firebird Database - incompatibility with expected lowercase columns #61232
Conversation
Firebird Databse - incompatibility with expected lowercase columns
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
| @@ -404,7 +404,9 @@ private function createQueryBuilder(string $alias = 'm'): QueryBuilder | |||
|
|
|||
| $alias .= '.'; | |||
|
|
|||
| if (!$this->driverConnection->getDatabasePlatform() instanceof OraclePlatform) { | |||
| // FirebirdPlatform ist not part of Doctrine/Dbal Package | |||
There was a problem hiding this comment.
which package is it part of then?
why can't we check for the FQCN?
There was a problem hiding this comment.
It's part of https://github.com/satwareAG/doctrine-firebird-driver.
We can check for \Satag\DoctrineFirebirdDriver\Platforms\FirebirdPlatform
|
Are you using the connection for the messenger exclusively? If so, you could use DBAL's portability middleware to control the casing of result columns. |
Firebird Database - incompatibility with expected lowercase columns
Fix ensures, for Firebird databases, the column names are consistently converted to lowercase before being processed by Doctrine Messenger. This resolves the incompatibility by providing Messenger with the expected lowercase column names, regardless of how Firebird returns them.
Because the FirebirdPlatform is not part of the doctrine/dbal package, I was unable to use instanceof for platform detection. Instead, I implemented a string comparison to check for Firebird as the database platform.