Skip to content

[BrowserKit] Add isFirstPage() and isLastPage() methods to History #21138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

[BrowserKit] Add isFirstPage() and isLastPage() methods to History #21138

merged 1 commit into from
Jun 29, 2025
+14 −0

Conversation

santysisi
Copy link
Contributor

This updates the BrowserKit documentation to demonstrate how to use the isFirstPage and isLastPage methods of the History class.

@carsonbot carsonbot added this to the 7.4 milestone Jun 26, 2025
@santysisi
Copy link
Contributor Author

Doc for this PR

@santysisi santysisi changed the title [BrowserKit] Add isFirstPage() and isLastPage() methods to History [BrowserKit] Add isFirstPage() and isLastPage() methods to History Jun 26, 2025
@santysisi santysisi force-pushed the feature/history-navigation-checks branch from fa36dcb to 586baa0 Compare June 26, 2025 13:05
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Jun 27, 2025
@carsonbot carsonbot modified the milestones: 7.4, next Jun 27, 2025
@santysisi santysisi mentioned this pull request Jun 27, 2025
Closed
@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Jun 29, 2025
@OskarStark OskarStark modified the milestones: next, 7.4 Jun 29, 2025
@santysisi santysisi force-pushed the feature/history-navigation-checks branch from 586baa0 to 9d67f32 Compare June 29, 2025 17:49
xabbuh
xabbuh reviewed Jun 29, 2025
View reviewed changes
components/browser_kit.rst

.. versionadded:: 7.4

The ``isFirstPage`` and ``isLastPage`` methods were introduced in Symfony 7.4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ``isFirstPage`` and ``isLastPage`` methods were introduced in Symfony 7.4.
The ``isFirstPage()`` and ``isLastPage()`` methods were introduced in Symfony 7.4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed while merging

@OskarStark
Copy link
Contributor

Thank you @santysisi.

@OskarStark OskarStark merged commit 889b43a into symfony:7.4 Jun 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@alamirault alamirault alamirault approved these changes

Assignees
No one assigned
Labels
BrowserKit Status: Reviewed
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
6 participants
@santysisi @OskarStark @xabbuh @alamirault @javiereguiluz @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy