feat(web): fetch all change sets on load, wait in the lobby #6445
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
269a0de to
ad1ee45
Compare
app/web/src/newhotness/Workspace.vue
Outdated
| } | ||
| router.push({ |
There was a problem hiding this comment.
We shouldn't need a router push here? Just make the lobby bool false so they see the page...
There was a problem hiding this comment.
ahh. makes sense
There's another issue here: it's getting stuck forever when creating a new change set. I have to fix that.
There was a problem hiding this comment.
The lobbyExit callback will mark the change set as ready to move it out of the lobby if it gets a 202.
ad1ee45 to
a9343b1
Compare
a9343b1 to
727baea
Compare
|
No longer seeing the createMTM issues, which may have been solved by keiser's changes? |
| @@ -306,51 +315,38 @@ onBeforeMount(async () => { | |||
| if (connectionShouldBeEnabled.value && heimdall.initCompleted.value) { | |||
| // NOTE(nick,wendy): this says "reconnect", but it must run once on startup. | |||
| await heimdall.bifrostReconnect(); | |||
| } else { | |||
There was a problem hiding this comment.
This was closing the websocket. Do we need to close it?
There was a problem hiding this comment.
huh... well... if someone gets un-auth'd/turned off (i dont know how that would get pushed down to the app) it would close the websocket—which would be desirable
917fb8a to
bb3012a
Compare
1cbca15 to
339ccaa
Compare
339ccaa to
812a238
Compare
Starts the user in the lobby, and runs "muspelheim", which runs niflheim against every open change set. Only then does it exit the lobby.
Lobby is controlled by the status of the niflheim queries, not the route.
Also sends the user to the lobby / muspelheims if the tab has been idle for 12 hours+.