Expose edda's parallel MV build limit as a configuration setting #6449
+96
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This maintains the previously hard-coded value as the default for the configuration setting, but it is now possible to change the limit on how many MVs edda will try to build at the same time without having to recompile edda. By being able to adjust this limit without having to rebuild edda, it will be easier/faster to tune the value for the running hardware.
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maintains the previously hard-coded value as the default for the configuration setting, but it is now possible to change the limit on how many MVs edda will try to build at the same time without having to recompile edda.
By being able to adjust this limit without having to rebuild edda, it will be easier/faster to tune the value for the running hardware.
edda's parallel MV build limit is now configurable by setting the
SI_EDDA__EDDA_PARALLEL_BUILD_LIMITenvironment variable, as well as via edda's config file.