fix(edda): Ensure new management edges propagate to the front end #6457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
The IncomingConnections MV currently includes both management connections and prop to prop connections. The management edges were backwards in this MV, which meant that when a new management edge was created (Component A -> Manages -> Component B), the component that gets triggered to rebuild is the one newly under management (Component B), only when building this MV, we're asking about the managed components (Component B -> Manages -> GO FIND THEM), not the managing components (GO FIND THEM BECAUSE THERE IS A NEW ONE NOW -> Manages -> Component B).
ef36520 to
66cb7d4
Compare
stack72
approved these changes
Jun 23, 2025
keeb
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IncomingConnections MV currently includes both management connections and prop to prop connections. The management edges were backwards in this MV, which meant that when a new management edge was created (Component A -> Manages -> Component B), the component that gets triggered to rebuild is the one newly under management (Component B), only when building this MV, we're asking about the managed components (Component B -> Manages -> GO FIND THEM, SORRY NO NEW ONES SO NO PATCH), not the managing components (GO FIND THEM BECAUSE THERE IS A NEW ONE NOW -> Manages -> Component B).
How does this PR change the system?
After this change, when a new management connection (Component A -> Manages -> Component B) is created, when Component B is triggered to rebuild, the new management connection is included and a patch is sent!
How was it tested?
via Dude Dad on GIPHY