Being more defensive here around the potential for bad data #6479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
We were seeing a rare error where `d` was undefined so `d.id` threw an exception
09a303a to
6851856
Compare
britmyerss
approved these changes
Jun 24, 2025
jkeiser
requested changes
Jun 24, 2025
| // TODO removal | ||
| const idx = cachedData.findIndex((d) => d.id === id); | ||
| const idx = cachedData.findIndex((d) => d && d.id === id); |
There was a problem hiding this comment.
I don't think we should do this without at least adding an error log when we get a falsey value--defensive programming is good but we're probably missing something important here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
Prevent exceptions. We were seeing a rare error where
dwas undefined sod.idthrew an exception