fix(web): Wait for bifrost to initialize before fetching the action view list from sqlite #6493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
jobelenus
requested changes
Jun 25, 2025
…iew list from sqlite This is the one case where we're rendering data before bifrost is initialized and before cold start finishes, which was causing a whole host of strange issues. Adding this flag to the context, allows the Apply button to render with a default 0 action count, and the action count updates when the query can finally run.
85e27d2 to
ba9682d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
This is the one case where we're rendering data before bifrost is initialized and before cold start finishes, which was causing a whole host of strange issues. Adding this flag to the context, allows the Apply button to render with a default 0 action count, and the action count updates when the query can finally run.
How was it tested?
Manually tested to ensure that loading an empty change set succeeds, loading a change set with actions shows 0 actions initially and the correct count after cold start completes, and flipping between change sets shows the accurate count as well.
via DREAMSTAGE on GIPHY