feat(web) - continuing work on the Management panel #6506
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
| 'flex flex-row items-center gap-xs [&>*]:text-sm [&>*]:font-bold', | ||
| themeClasses('[&>*]:border-neutral-400', '[&>*]:border-neutral-600'), |
There was a problem hiding this comment.
Tailwind child selectors allow us to avoid redundant styles.
| mono | ||
| :class="themeClasses('text-green-light-mode', 'text-green-dark-mode')" | ||
| > | ||
| <!-- TODO(WENDY) - schema variant name goes here --> |
There was a problem hiding this comment.
Ah whoops - will remove this comment in my next PR 😅
| @@ -114,6 +113,7 @@ import { | |||
| startWindowResizeEmitter, | |||
| } from "./logic_composables/emitters"; | |||
| import { tokensByWorkspacePk } from "./logic_composables/tokens"; | |||
| import ComponentPage from "./ComponentDetails.vue"; | |||
There was a problem hiding this comment.
Avoiding a name conflict!
There was a problem hiding this comment.
@wendybujalski functionality wise it's looking great! I have it running here and I love it
WRT the changes to the webworker etc, I would love @jobelenus to cast his eyes over it to make sure he's good with them - this is an area I am not 100% sure about
| /* TODO(Wendy) - temporary color classes for the new UI */ | ||
| .text-purple { | ||
| color: #d4b4fe; | ||
| } | ||
|
|
||
| .text-green-light-mode { | ||
| color: #3b8e48; | ||
| } | ||
|
|
||
| .text-green-dark-mode { | ||
| color: #b2dfb9; | ||
| } |
There was a problem hiding this comment.
These are colors we're using in the new UI which are not compliant with the old color system. Eventually we should revamp that system to include these colors.
There was a problem hiding this comment.
Thank you to @jobelenus for his advice/guidance in how best to make these changes to the webworker and the Context!
Finishes most of ENG-3083
Last bit of work left is to finish the UX for and wire up the "add components to be managed" input.