fix: log configuring when running under spawn and add --log-format #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue with logging configuration when using multiprocessing 'spawn' method on macOS. The spawn method reimports all modules which caused logging configuration to be lost. Added `--log-format` argument to easily customize logging format across all processes, including spawned child processes.
s3rius
previously approved these changes
Mar 25, 2025
|
Can you please run |
sure |
|
Thanks for the pull request. It makes a lot of sense, even though I haven't thought of it. |
s3rius
approved these changes
Mar 25, 2025
s3rius
pushed a commit
that referenced
this pull request
Apr 4, 2025
) * fix: log configuring when running under spawn and add --log-format Fixed issue with logging configuration when using multiprocessing 'spawn' method on macOS. The spawn method reimports all modules which caused logging configuration to be lost. Added `--log-format` argument to easily customize logging format across all processes, including spawned child processes. * fix linting and formatting --------- Co-authored-by: Ilya Volnistov <i.volnistov@gaijin.team>
s3rius
pushed a commit
that referenced
this pull request
Apr 4, 2025
) * fix: log configuring when running under spawn and add --log-format Fixed issue with logging configuration when using multiprocessing 'spawn' method on macOS. The spawn method reimports all modules which caused logging configuration to be lost. Added `--log-format` argument to easily customize logging format across all processes, including spawned child processes. * fix linting and formatting --------- Co-authored-by: Ilya Volnistov <i.volnistov@gaijin.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical explanation of the issue:
Problem in taskiq code:
PR fixes:
Now DEBUG level logs will be correctly displayed in all child processes, even when using the 'spawn' method, and log formatting settings can be easily customized.