Skip to content

atime_versions() works with package in sub-dir of git repo #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 28, 2025
Merged

atime_versions() works with package in sub-dir of git repo #80

merged 12 commits into from
Apr 28, 2025

Conversation

tdhock
Copy link
Owner

@tdhock tdhock commented Apr 26, 2025

Closes #79

example code:

remotes::install_github("tdhock/atime@pkg-subdir")
gdir <- tempfile()
dir.create(gdir)
git2r::clone("https://github.com/tdhock/grates", gdir)
glist <- atime::atime_versions(
  file.path(gdir,"pkg"),
  current = "1aae646888dcedb128c9076d9bd53fcb4075dcda",
  old     = "51056b9c4363797023da4572bde07e345ce57d9c",
  setup   = date_vec <- rep(Sys.Date(), N),
  expr    = grates::as_yearmonth(date_vec))
plot(glist)

I see this result
image

@TimTaylor please review. does it work for you too?

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.65%. Comparing base (6ba1cfe) to head (03010be).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
R/versions.R 87.50% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   79.31%   79.65%   +0.33%     
==========================================
  Files           5        5              
  Lines         846      865      +19     
==========================================
+ Hits          671      689      +18     
- Misses        175      176       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimTaylor
Copy link

Works a treat. Thank you!

@tdhock
Copy link
Owner Author

tdhock commented Apr 27, 2025

great!

@tdhock tdhock merged commit a293d4b into main Apr 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

working git repositories with package not at the top level
3 participants
@tdhock @codecov-commenter @TimTaylor
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy