Rename *InferenceDatapointInput in the client
#2130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the "InferenceDatapointInput" suffix in client types to "DatapointInsert" for improved clarity.
- Renames ChatInferenceDatapointInput to ChatDatapointInsert
- Renames JsonInferenceDatapointInput to JsonDatapointInsert
- Updates tests and type definitions while preserving deprecated aliases with warnings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tensorzero-internal/src/endpoints/datasets.rs | Renamed types in deserialization and struct definitions |
| clients/python/tests/test_client.py | Updated test cases to use new types and preserved deprecated usage |
| clients/python/tensorzero/types.py | Refactored type declarations including deprecation wrappers |
| clients/python/tensorzero/tensorzero.pyi | Updated type annotations to reflect the renaming |
| clients/python/tensorzero/init.py | Revised exports with deprecated types noted |
Comments suppressed due to low confidence (2)
clients/python/tests/test_client.py:2897
- Consider adding tests to explicitly verify that using ChatInferenceDatapointInput triggers a DeprecationWarning, ensuring the deprecation mechanism works as intended.
ChatInferenceDatapointInput(
clients/python/tensorzero/types.py:433
- Verify that the deprecation warning's stacklevel (currently set to 2) correctly points to the user's call site. This ensures that the warning message provides clear guidance to developers.
# CAREFUL: deprecated
virajmehta
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing to use a suffix with
Inputif the class hasinputandoutputfields.Important
Renames
ChatInferenceDatapointInputandJsonInferenceDatapointInputtoChatDatapointInsertandJsonDatapointInsert, respectively, with deprecation of old names.ChatInferenceDatapointInputtoChatDatapointInsertintypes.pyanddatasets.rs.JsonInferenceDatapointInputtoJsonDatapointInsertintypes.pyanddatasets.rs.ChatInferenceDatapointInputandJsonInferenceDatapointInputare marked as deprecated but still available for backward compatibility.test_client.pyto use new class names and ensure deprecated classes are still supported.This description was created by
for 265be3c. You can customize this summary. It will automatically update as commits are pushed.