Add legacy asterisk handling and tests

tj · shadowspawn · Jan 31, 2020 · Jan 12, 2020 · Jan 12, 2020 · Jan 12, 2020
commit b28a0889a8a9913afda1d6488c0e1791d0813304
diff --git a/index.js b/index.js
@@ -824,8 +824,12 @@ Command.prototype._parseCommand = function(operands, unknown) {
       });
 
       this._actionHandler(args);
-      // this.emit('command:' + this.name(), operands, unknown); // still needed????
-    } else {
+      this.emit('command:' + this.name(), operands, unknown); // retain ????
+    } else if (operands.length) {
+      // legacy behaviours, command and listener
+      if (this._findCommand('*')) {
+        this._dispatchSubcommand('*', operands, unknown);
+      }
       this.emit('command:*', operands, unknown);
     }
   }

diff --git a/tests/command.asterisk.test.js b/tests/command.asterisk.test.js
@@ -10,14 +10,30 @@ const commander = require('../');
 //
 // Historical: the event 'command:*' used to also be shared by the action handler on the program.
 
-describe.skip(".command('*')", () => {
+describe(".command('*')", () => {
+  // Use internal knowledge to suppress output to keep test output clean.
+  let writeMock;
+
+  beforeAll(() => {
+    writeMock = jest.spyOn(process.stdout, 'write').mockImplementation(() => { });
+  });
+
+  afterAll(() => {
+    writeMock.mockRestore();
+  });
+
   test('when no arguments then asterisk action not called', () => {
     const mockAction = jest.fn();
     const program = new commander.Command();
     program
+      .exitOverride() // to catch help
       .command('*')
       .action(mockAction);
-    program.parse(['node', 'test']);
+    try {
+      program.parse(['node', 'test']);
+    } catch (err) {
+      ;
+    }
     expect(mockAction).not.toHaveBeenCalled();
   });
 
@@ -58,7 +74,7 @@ describe.skip(".command('*')", () => {
 });
 
 // Test .on explicitly rather than assuming covered by .command
-describe.skip(".on('command:*')", () => {
+describe(".on('command:*')", () => {
   test('when no arguments then listener not called', () => {
     const mockAction = jest.fn();
     const program = new commander.Command();