Skip to content

Collect bazel target information #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Collect bazel target information #715

wants to merge 4 commits into from

Conversation

gnalh
Copy link
Collaborator

@gnalh gnalh commented Jul 9, 2025

No description provided.

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jul 9, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.91184% with 179 lines in your changes missing coverage. Please review.

Project coverage is 72.78%. Comparing base (514ca1e) to head (aa4ceee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/context.rs 6.66% 112 Missing ⚠️
context-js/src/lib.rs 0.00% 18 Missing ⚠️
bundle/src/bundler.rs 23.52% 13 Missing ⚠️
context-py/src/lib.rs 0.00% 12 Missing ⚠️
cli/src/upload_command.rs 52.17% 11 Missing ⚠️
context/src/junit/bindings.rs 42.85% 8 Missing ⚠️
context/src/bazel_bep/parser.rs 92.10% 3 Missing ⚠️
context/src/bazel_bep/common.rs 95.00% 1 Missing ⚠️
test_report/src/report.rs 96.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   72.84%   72.78%   -0.07%     
==========================================
  Files          69       69              
  Lines       15827    16148     +321     
==========================================
+ Hits        11529    11753     +224     
- Misses       4298     4395      +97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented Jul 10, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@trunk-staging-io Trunk-Staging.io
Copy link

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jul 10, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@gnalh gnalh marked this pull request as ready for review July 10, 2025 04:30
@gnalh gnalh requested a review from cmillar-trunk as a code owner July 10, 2025 04:30
cmillar-trunk
cmillar-trunk reviewed Jul 10, 2025
View reviewed changes
@gnalh gnalh force-pushed the gabe/surface-target branch from f2ec176 to 1109aa2 Compare July 10, 2025 16:31
@gnalh gnalh force-pushed the gabe/surface-target branch from 1109aa2 to 76a7ebd Compare July 10, 2025 16:49
@gnalh gnalh force-pushed the gabe/surface-target branch from b9d104c to 34d9311 Compare July 10, 2025 17:58
@gnalh gnalh force-pushed the gabe/surface-target branch from 34d9311 to 553f35f Compare July 10, 2025 18:26
@gnalh
Copy link
Collaborator Author

gnalh commented Jul 10, 2025

Really need to get code coverage working on context-* and cli. The current report is misleading.

@gnalh gnalh force-pushed the gabe/surface-target branch from 553f35f to 76a7ebd Compare July 11, 2025 03:53
@gnalh gnalh force-pushed the gabe/surface-target branch from 5eb1287 to e31a2d2 Compare July 11, 2025 04:18
@gnalh gnalh force-pushed the gabe/surface-target branch from 285af67 to aa4ceee Compare July 11, 2025 19:36
@gnalh gnalh mentioned this pull request Jul 14, 2025
Merged
trunk-io bot pushed a commit that referenced this pull request Jul 14, 2025
@gnalh
Include resolved_label in meta.json (#719)
71f5ed7 
This is a sibling PR of #715. We haven't migrated to using pre-processed logic yet, so we need to also have support for this flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmillar-trunk cmillar-trunk cmillar-trunk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnalh @codecov-commenter @cmillar-trunk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy