Skip to content

Add additional environment variables used by python networking stack #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 27, 2025
Merged

Add additional environment variables used by python networking stack #1032

merged 18 commits into from
May 27, 2025

Conversation

EliSchleifer
Copy link
Member

@EliSchleifer EliSchleifer commented May 23, 2025 •
edited
Loading

  1. Add additional environment variables used by python networking stack. Passes thru additional environment variable to PIP to unblock pip and other PYTHON libraries that use proxy info. Fixes broken trunk check in OpenAI Codex.
  2. Updates node to latest LTS 22.16.0
  3. Fixes some broken tests

@EliSchleifer
Add additional environment variables used by python networking stack
d057a57 
Add additional environment variables used by python networking stack
@trunk-staging-io Trunk-Staging.io
Copy link

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

@EliSchleifer EliSchleifer requested a review from dapirian May 23, 2025 19:08
@EliSchleifer EliSchleifer enabled auto-merge (squash) May 23, 2025 19:11
@chip-agent Chip Agent
Copy link

chip-agent bot commented May 23, 2025 •
edited
Loading

Okay, I see a few interesting changes in this PR:

  • Node Version Upgrade: The PR upgrades the node version from 18 to 22 in several action files.
  • .trunk/trunk.yaml Updates: There are updates to the trunk CLI version, configs ref, and eslint version. A runtimes section was added.
  • cfnlint Update: The cfnlint version was updated.

It's possible that the node version upgrade or the linter version upgrades are causing compatibility issues that are leading to test failures. Since I don't have the test logs, I'll have to make some educated guesses.

Here's a plan of action:

Summary:
The PR updates Node.js, linters, and other dependencies. Test failures are likely due to incompatibilities introduced by these updates.

Root Cause Analysis:
The most likely root cause is that the updated versions of Node.js or the linters (eslint, cfnlint) have introduced changes that are causing existing tests to fail. It's also possible that the new runtimes section in .trunk/trunk.yaml is causing issues.

Resolution Plan:

  1. Investigate Node.js Compatibility:
    • Check if any tests are failing due to changes in Node.js behavior between versions 18 and 22.
    • Look for any deprecated APIs or features that are being used in the tests and need to be updated.
  2. Investigate Linter Compatibility:
    • Check if the updated versions of eslint or cfnlint have introduced new rules or stricter checks that are causing linting errors.
    • If so, either update the code to comply with the new linting rules or adjust the linter configuration to allow the existing code.
  3. Examine the runtimes Section:
    • Ensure that the runtimes section in .trunk/trunk.yaml is correctly configured and not causing any conflicts with the existing environment.
  4. Re-run Tests:
    • After making the necessary changes, re-run the tests to see if the failures have been resolved.

Since I don't have access to the test logs, I can't provide more specific guidance. The PR author will need to investigate the test failures and determine the exact cause based on the error messages and stack traces.

Is this helpful? Click the 👍/👎 buttons below to let us know!

Thumbs UpThumbs Down

Icons by Icons8

@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented May 23, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Testing linter hadolint test CUSTOM Hadolint exited with exit code -6 due to rosetta error: invalid gdt selector index 0. Logs ↗︎
Flaky Test Failure Summary Logs
Testing linter trunk-toolbox test do_not_land The linter test failed to find expected issues in the file. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@trunk-staging-io Trunk-Staging.io
Copy link

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Testing tool awscli aws --version The expected object did not match the received object, with 'exitCode' being the main difference. Logs ↗︎
Testing tool sourcery sourcery --version The expected output did not match the received output, with a difference in the 'exitCode' property. Logs ↗︎
Testing tool asciinema asciinema --version The expected object did not match the received object, with 'exitCode' being the main difference. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@trunk-io Trunk.io
Copy link

trunk-io bot commented May 23, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Testing linter hadolint test CUSTOM Hadolint exited with exit code -6 due to rosetta error: invalid gdt selector index 0. Logs ↗︎
Flaky Test Failure Summary Logs
Testing linter trunk-toolbox test do_not_land The linter test failed to find expected issues in the file. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@TylerJang27
Copy link
Collaborator

Working on addressing some of the blocking/failing tests in this PR in #1027

@TylerJang27
Copy link
Collaborator

Up to you on if you want to land this first, but I think there are a couple things that this PR doesn't capture and a couple things my PR doesn't capture. I can address the conflicts after

@EliSchleifer
Copy link
Member Author

@TylerJang27 - Happy for you to land first and then we can merge in

@EliSchleifer
Copy link
Member Author

would like to land this so we can unblock codex users

@EliSchleifer EliSchleifer merged commit 4b79374 into main May 27, 2025
15 checks passed
@EliSchleifer EliSchleifer deleted the eli/update-env-for-python branch May 27, 2025 05:01
@TylerJang27 TylerJang27 mentioned this pull request May 27, 2025
Merged
TylerJang27 added a commit that referenced this pull request May 27, 2025
@TylerJang27
(Chore): Fix repo tests (#1027)
76ba8d9 
Additional cleanup as follow-up to #1032.

Mostly aligning snapshots to match the test versions for cleanliness.
Other notes:
- Semgrep problem with no issues being reported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapirian dapirian dapirian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EliSchleifer @TylerJang27 @dapirian
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy