Skip to content

Fix #23: Add Vue 3 support #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2021
Merged

Fix #23: Add Vue 3 support #26

merged 1 commit into from
Aug 26, 2021

Conversation

clayadavis
Copy link
Contributor

Towards #23 this PR adds basic Vue 3 support, but doesn't touch Composition API.

Built dist/ files are included for ease of testing, but the real diff is just a few lines in src/sse-manager.js

tserkov
tserkov requested changes Aug 22, 2021
View reviewed changes
Copy link
Owner

@tserkov tserkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Clay,

Thanks for tackling this. I've made one change request, and then we'll get this merged.

If you'd like to save me a commit, you can go ahead and increment package.json to 2.4.0 as well.

Thanks again!

@clayadavis clayadavis force-pushed the vue3-support branch 2 times, most recently from d9da79b to 40f7fee Compare August 23, 2021 01:19
tserkov
tserkov approved these changes Aug 25, 2021
View reviewed changes
Copy link
Owner

@tserkov tserkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Let me get 2.3.1 out the door (fixes bug in forcePolyfill) and then I'll push this out right after.

@tserkov tserkov merged commit f91eaa0 into tserkov:v2 Aug 26, 2021
tserkov added a commit that referenced this pull request Aug 26, 2021
@tserkov
release 2.4.0
7463952 
feat: support vue 3 (#26)
@clayadavis clayadavis deleted the vue3-support branch December 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tserkov tserkov tserkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clayadavis @tserkov
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy