[fix] Change JWT key name for following RFC6749 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NatLee 非常感謝修正, 但為了維持教學文的簡單性(我暫時不太想 merge 進去), |
|
@twtrubiks 沒問題的，謝謝！ |
|
補上去了, commit 51955b84db0, 謝謝 |
|
好的，感謝大大 那麼這個commit就先close了 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi！
感謝大大的教學文，但我在測試API的時候
發現原本的 simplejwt 套件內回傳的 token key name跟 RFC 上面的 key name 不同
https://www.rfc-editor.org/rfc/rfc6749#section-4.1.4
所以看起來是要override以符合規範
我的更動是新增一個model，然後參照這邊做修改
https://stackoverflow.com/questions/54544978/customizing-jwt-response-from-django-rest-framework-simplejwt
js的部分也修改完成，已測試都OK
再麻煩review一下，謝謝！