Closed
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I have searched for related issues and found none that match my proposal.
- I have searched the current rule list and found no rules that match my proposal.
- I have read the FAQ and my problem is not listed.
Relevant Package
rule-tester
My proposal is suitable for this project
- I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).
Description
// packages/rule-tester/tests/RuleTester.test.ts
it('passes with no output', () => {
expect(() => {
ruleTester.run('my-rule', rule, {
invalid: [
{
code: 'foo',
errors: [{ messageId: 'error' }],
},
],
valid: [],
});
}).not.toThrow();
});
it('passes with null output', () => {
expect(() => {
ruleTester.run('my-rule', rule, {
invalid: [
{
code: 'foo',
errors: [{ messageId: 'error' }],
},
],
valid: [],
});
}).not.toThrow();
});These two test cases have almost the same meaning and are written in exactly the same code.
- Remove duplicates
OR - If duplication is absolutely necessary, please state in a comment why it is necessary.
OR - write it clearly.
it('passes with null output', () => {
expect(() => {
ruleTester.run('my-rule', rule, {
invalid: [
{
code: 'foo',
errors: [{ messageId: 'error' }],
output: null,
},
],
valid: [],
});
}).not.toThrow();
});Additional Info
❤
Is this an issue with repo maintainance?