Skip to content

chore(rule-tester): correct typo in test #11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

cseas
Copy link
Contributor

@cseas cseas commented Jun 24, 2025

PR Checklist

Overview

Modified the test as suggested in #11285 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cseas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7bc1a91
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/685b20a5557eba000898570b
😎 Deploy Preview https://deploy-preview-11338--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jun 24, 2025

View your CI Pipeline Execution ↗ for commit 7bc1a91.

Command Status Duration Result
nx run-many -t typecheck ✅ Succeeded 1m 54s View ↗
nx run-many -t lint ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded <1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 4s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-24 22:09:13 UTC

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell.

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 24, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) June 24, 2025 22:03
@kirkwaiblinger kirkwaiblinger disabled auto-merge June 24, 2025 22:03
@kirkwaiblinger kirkwaiblinger changed the title test: correct null output test in RuleTester chore(rule-tester): correct typo in test Jun 24, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) June 24, 2025 22:04
@kirkwaiblinger kirkwaiblinger merged commit 9dc91aa into typescript-eslint:main Jun 24, 2025
64 checks passed
@cseas cseas deleted the test-RuleTester-null branch June 25, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: duplicated test cases in RuleTester.test.ts
4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy