Skip to content

feat(eslint-plugin): [no-unnecessary-condition] enable checkTypePredicates by default #10721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(eslint-plugin): [no-unnecessary-condition] enable checkTypePredicates by default #10721

wants to merge 2 commits into from

Conversation

mdm317
Copy link
Contributor

@mdm317 mdm317 commented Jan 28, 2025

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 107a4c2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67984c2037a57600081448cc
😎 Deploy Preview https://deploy-preview-10721--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 107a4c2.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 12:17:28 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (94e8098) to head (107a4c2).
Report is 309 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10721      +/-   ##
==========================================
+ Coverage   87.26%   87.27%   +0.01%     
==========================================
  Files         450      450              
  Lines       15712    15712              
  Branches     4600     4600              
==========================================
+ Hits        13711    13713       +2     
+ Misses       1645     1643       -2     
  Partials      356      356
Flag Coverage Δ
unittest 87.27% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.16% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdm317 mdm317 marked this pull request as ready for review January 28, 2025 03:39
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the note that we can't merge this until work on the next major version with breaking behavioral/config changes is started. 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the DO NOT MERGE PRs which should not be merged yet label Jan 28, 2025
@JoshuaKGoldberg
Copy link
Member

Making this a draft per #9923 (comment) so it doesn't show up on our to-review queues.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft January 28, 2025 12:16
@JoshuaKGoldberg JoshuaKGoldberg added the breaking change This change will require a new major version to be released label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released DO NOT MERGE PRs which should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configs: [no-unnecessary-condition] Enable checkTypePredicates by default
2 participants
@mdm317 @JoshuaKGoldberg
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy