chore: migrate `eslint-plugin-import` to `eslint-plugin-import-x` #11217

JounQin · 2025-05-14T14:26:35Z

PR Checklist

Addresses an existing open issue: fixes Repo: migrate eslint-plugin-import to eslint-plugin-import-x #11212
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Old measurements (see later for updated ones)

Before:

 typescript-eslint on  main ❯ TIMING=1 y eslint .
Rule                                               | Time (ms) | Relative
:--------------------------------------------------|----------:|--------:
@typescript-eslint/no-unsafe-assignment            |  5458.780 |    22.9%
@typescript-eslint/internal/plugin-test-formatting |  3047.222 |    12.8%
@typescript-eslint/no-floating-promises            |  2288.399 |     9.6%
@typescript-eslint/no-misused-promises             |  2215.349 |     9.3%
@typescript-eslint/no-unsafe-return                |  1609.052 |     6.8%
@typescript-eslint/no-deprecated                   |  1049.075 |     4.4%
@typescript-eslint/no-unsafe-argument              |   954.879 |     4.0%
@typescript-eslint/no-unsafe-member-access         |   528.152 |     2.2%
import/no-duplicates                               |   501.363 |     2.1%
perfectionist/sort-objects                         |   373.923 |     1.6%
via .NET via  v24.0.1 took 1m13s

 typescript-eslint on  chore/import-x [+] ❯ TIMING=1 y eslint .
Rule                                               | Time (ms) | Relative
:--------------------------------------------------|----------:|--------:
@typescript-eslint/no-unsafe-assignment            |  3212.736 |    15.9%
@typescript-eslint/internal/plugin-test-formatting |  3052.515 |    15.1%
@typescript-eslint/no-floating-promises            |  2319.146 |    11.5%
@typescript-eslint/no-misused-promises             |  2253.580 |    11.2%
@typescript-eslint/no-unsafe-return                |  1785.357 |     8.9%
@typescript-eslint/no-unsafe-argument              |   932.104 |     4.6%
@typescript-eslint/no-deprecated                   |   906.925 |     4.5%
@typescript-eslint/no-unsafe-member-access         |   528.508 |     2.6%
@typescript-eslint/no-unnecessary-condition        |   321.524 |     1.6%
perfectionist/sort-objects                         |   298.678 |     1.5%
via .NET via  v24.0.1 took 1m8s

For a single ESLint plugin migration, I believe from 1m13s to 1m8s is already good enough, and it founds a false positive that @docusaurus/plugin-content-blog should be listed in dependencies for website, because eslint-plugin-import-x is a TypeScript rewrite started at un-ts/eslint-plugin-import-x#42 and we fixed several hidden bugs thanks to TypeScript!

(I don't know why nx complains about react-helmet-async version incompatible with @docusaurus/core's, see also https://app.unpkg.com/@docusaurus/core@3.7.0/files/package.json#L63, so I'm locking it same way to make nx happy.)

cc @JoshuaKGoldberg

typescript-eslint · 2025-05-14T14:26:39Z

Thanks for the PR, @JounQin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-05-14T14:26:46Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`9370841`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/685be5a50e77520008048843
😎 Deploy Preview	https://deploy-preview-11217--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 3 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-05-14T14:27:32Z

View your CI Pipeline Execution ↗ for commit 9370841.

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 5s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 58s	View ↗
`nx run types:build`	✅ Succeeded	<1s	View ↗
`nx run-many -t lint`	✅ Succeeded	10s	View ↗
`nx run integration-tests:test`	✅ Succeeded	<1s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	<1s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	<1s	View ↗
`nx run generate-configs`	✅ Succeeded	5s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-06-25 12:21:11 UTC

JoshuaKGoldberg · 2025-05-30T14:25:37Z

@JounQin those statistics look surprising to me. All lint rules are slower in the second one. Why would that be the case?

I'm out traveling and can't do much testing at the moment, otherwise I'd post some hyperfine statistics.

JounQin · 2025-05-30T14:31:55Z

I don't know, eslint-plugin-import-x is powered by @typescript-eslint/utils under the hood, eslint-plugin-import is wrote without top level tools.

Update: eslint-plugin-import-x now doesn't have @typescript-eslint/utils as dependency anymore.

codecov · 2025-05-30T16:27:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (3e54520) to head (9370841).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11217   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         501      501           
  Lines       50919    50919           
  Branches     8387     8387           
=======================================
  Hits        46256    46256           
  Misses       4648     4648           
  Partials       15       15

Flag	Coverage Δ
unittest	`90.84% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

The perf boost is nice, but there are a lot of lockfile & package dep changes that are not needed for this. Could you please revert any that aren't actually necessary / newly caught issues (e.g. the Docusaurus 3.7 bump)?

I think we need a relatively clean PR showing that the lockfile doesn't get significantly larger from this change. #11212 (comment) raises a good point that we already have a lot of deps from multiple plugins in this package. The size of node_modules is a performance factor for us too (#11204). I think we'd want to know how "bad" the duplication is before making the switch-or-not call.

packages/website/package.json

close #15599

JoshuaKGoldberg · 2025-06-26T22:04:26Z

Thanks for getting this to a reviewable state. Seeing the lockfile and having a clean slate to run performance measurements locally on was helpful. Conclusions commented here: #11212 (comment)

tl;dr: this won't be a net positive unless & until the other *-x plugins are ready to be swapped over too.

I'll go ahead and close this out to keep the queue small. Looking forward to being able to reevaluate later this year though! 💙

JounQin · 2025-06-27T05:55:37Z

packages/project-service/package.json

@@ -53,6 +53,9 @@
    "@typescript-eslint/types": "^8.35.0",
    "debug": "^4.3.4"
  },
+  "devDependencies": {
+    "vitest": "^3.1.3"


@JoshuaKGoldberg By the way, this is found by import-x.

And also #11265

JounQin mentioned this pull request May 14, 2025

Repo: migrate eslint-plugin-import to eslint-plugin-import-x #11212

Open

JounQin force-pushed the chore/import-x branch from e1bf907 to 939bf24 Compare May 30, 2025 16:27

JounQin force-pushed the chore/import-x branch 4 times, most recently from fc1ebc7 to 36cf5b1 Compare June 2, 2025 14:05

JoshuaKGoldberg requested changes Jun 9, 2025

View reviewed changes

packages/website/package.json Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 9, 2025

chore: migrate eslint-plugin-import to eslint-plugin-import-x

db43dab

close #15599

JounQin force-pushed the chore/import-x branch from 36cf5b1 to db43dab Compare June 13, 2025 13:17

JounQin requested a review from JoshuaKGoldberg June 13, 2025 13:17

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 13, 2025

JoshuaKGoldberg added 2 commits June 25, 2025 07:56

Merge branch 'main'

ac2b174

Merge branch 'main'

9370841

JoshuaKGoldberg closed this Jun 26, 2025

JounQin deleted the chore/import-x branch June 27, 2025 01:15

JounQin commented Jun 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: migrate `eslint-plugin-import` to `eslint-plugin-import-x` #11217

chore: migrate `eslint-plugin-import` to `eslint-plugin-import-x` #11217

JounQin commented May 14, 2025 •

edited by JoshuaKGoldberg

Loading

Uh oh!

typescript-eslint bot commented May 14, 2025

Uh oh!

netlify bot commented May 14, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented May 14, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg commented May 30, 2025

Uh oh!

JounQin commented May 30, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 30, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

JoshuaKGoldberg commented Jun 26, 2025

Uh oh!

JounQin Jun 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

chore: migrate eslint-plugin-import to eslint-plugin-import-x #11217

chore: migrate eslint-plugin-import to eslint-plugin-import-x #11217

Conversation

JounQin commented May 14, 2025 • edited by JoshuaKGoldberg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented May 14, 2025

Uh oh!

netlify bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commented May 30, 2025

Uh oh!

JounQin commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg commented Jun 26, 2025

Uh oh!

JounQin Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

chore: migrate `eslint-plugin-import` to `eslint-plugin-import-x` #11217

chore: migrate `eslint-plugin-import` to `eslint-plugin-import-x` #11217

JounQin commented May 14, 2025 •

edited by JoshuaKGoldberg

Loading

netlify bot commented May 14, 2025 •

edited

Loading

nx-cloud bot commented May 14, 2025 •

edited

Loading

JounQin commented May 30, 2025 •

edited

Loading

codecov bot commented May 30, 2025 •

edited

Loading

JounQin Jun 27, 2025 •

edited

Loading