Skip to content

chore(eslint-plugin): switch auto-generated test cases to hand-written in consistent-type-assertions.test.ts #11312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Jun 17, 2025

PR Checklist

Overview

Change dynamic test cases using spread and map to handwritten ones.

🚀

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 14ddf7a
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/685195970add9a0008b1e9ca
😎 Deploy Preview https://deploy-preview-11312--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jun 17, 2025

View your CI Pipeline Execution ↗ for commit 14ddf7a.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 4m 58s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 51s View ↗
nx run-many -t lint ✅ Succeeded 12s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
nx run types:build ✅ Succeeded 1s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 7s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
nx run generate-configs ✅ Succeeded 4s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 16:30:00 UTC

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Huge, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2e35e3a into typescript-eslint:main Jun 23, 2025
73 of 76 checks passed
@y-hsgw y-hsgw deleted the chore/consistent-type-assertions branch June 23, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: [consistent-type-assertions.test.ts] Switch auto-generated test cases to hand-written
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy