-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: mention ESLint's defineConfig() #11335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: mention ESLint's defineConfig() #11335
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit 8dc5475.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11335 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 501 501
Lines 50911 50919 +8
Branches 8383 8387 +4
=======================================
+ Hits 46248 46256 +8
Misses 4648 4648
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PR Checklist
defineConfig
(untiltseslint.config
is deprecated) #11313Overview
Adds an aside under Quickstart explaining the transient
defineConfig()
situation, along with a similar note under thetypescript-eslint
package docs.I experimented for a bit splitting existing
tseslint.config
code blocks into tabs as suggested by the issue. That felt more confusing to me: that it was almost suggesting writing to files. Explaining the difference would have taken up even more previous docs space.💖