Fix parsing panic if variables are not defined #269

yiranwang52 · 2019-09-20T04:08:09Z

evelynl94 · 2019-09-20T04:13:00Z

lib/parser/dockerfile/base.go

@@ -70,6 +70,9 @@ func (d *baseDirective) replaceVars(vars map[string]string) error {
 	if err != nil {
 		return d.err(fmt.Errorf("Failed to replace variables in input: %s", err))
 	}
+	if len(replaced) == 0 {
+		return d.err(fmt.Errorf("Empty args after replacing variables: %s", err))


Fix parsing panic if variables are not defined

9ddb3b6

evelynl94 reviewed Sep 20, 2019

View reviewed changes

Yiran Wang added 2 commits September 19, 2019 21:14

fix

bd5bcb8

fix

c4b5232

evelynl94 approved these changes Sep 20, 2019

View reviewed changes

yiranwang52 merged commit 27daadc into master Sep 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix parsing panic if variables are not defined #269

Fix parsing panic if variables are not defined #269

yiranwang52 commented Sep 20, 2019

evelynl94 Sep 20, 2019

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Fix parsing panic if variables are not defined #269

Fix parsing panic if variables are not defined #269

Conversation

yiranwang52 commented Sep 20, 2019

evelynl94 Sep 20, 2019

Choose a reason for hiding this comment

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.