Skip to content

v13: Validation of form should only happen after form is invalid #15074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjarnef opened this issue Oct 31, 2023 · 3 comments
Closed

v13: Validation of form should only happen after form is invalid #15074

bjarnef opened this issue Oct 31, 2023 · 3 comments
Labels
status/idea The ideas in this issue are great idea, we're not ready to work on it in the near future. type/bug

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Oct 31, 2023

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.0

Bug summary

I noticed the new login form in v13/dev, but it seems the validation trigger after blur.
Best practise is that it first happen after form has been submitted (invalid).

image

Specifics

No response

Steps to reproduce

Set focus in username/email field and click elsewhere to blur.

image

Next each time a character is typed the validation message updates.

image

Expected result / actual result

No response

Copy link

Hi there @bjarnef!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard
Copy link
Contributor

Hi @bjarnef, thanks for reporting this. I generally concur that it doesn't work well on the login screen. Unfortunately, this is the only option available to us through the UI library at the moment. We will consider building in more options to control when the validation happens, so I'll go ahead and create a discussion on the UI library.

There are a few reasons why we chose to go down this route with "blur", and I am not convinced that neither blur nor submit is considered a best practice per se. This article from Smashing Magazine says otherwise, for instance.

However, since we don't have good server validation from the backend that can be matched to individual fields, we might consider it being more user-friendly behavior to validate on submit in this particular case. I will leave it up to the UI library discussion to implement more functionality. We will need it for sure when we start implementing validation in Bellissima.

@iOvergaard iOvergaard closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
@iOvergaard iOvergaard added the status/idea The ideas in this issue are great idea, we're not ready to work on it in the near future. label Nov 3, 2023
@iOvergaard
Copy link
Contributor

I have created a discussion on the Umbraco UI Library to follow through with a holistic perspective on validation: umbraco/Umbraco.UI#640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/idea The ideas in this issue are great idea, we're not ready to work on it in the near future. type/bug
Projects
None yet
Development

No branches or pull requests

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy