Add ability to add/remove watchers on an issue #29
Conversation
I completely agree. I tried to avoid concurrent callback problems by creating the magit-section before requesting the watchers API, saving the location of the section body. It "works", but the problem is that the inserted text isn't really part of the section: you can't collapse it or expand it. It doesn't seem like you can add text to a magit-section outside of the So the solution should be to fetch the data, then create the section, like It seems like it would work if "Other" was at the bottom of the buffer, but that doesn't seem right to me. Comments should be at the bottom, since there can be indefinitely many of them.
Done: b6a8c95
Did you mean this for
Fixed 🤦: 994d5fb. |
There is another option. Trigger the comments load in the callback of the function that shows the watchers after they are obtained (asynchronously) from the API. While the watchers are loading, we are able to see the rest of fields. When the watchers finish loading they are shown and the comments are requested (asynchronously) to the API
|
18a2f68 to
8685301
Compare
In
jira-detail-mode,wpops up a transient with commands for adding or removing a user from the watchers list. To make that easier to use, I also added a table mapping Jira display names to account IDs. Now we can offer completion when prompting for a user name.It's not the best to have the watchers commands in a nested transient. There's plenty of room left in
jira-detail--actions-menu. I originally wanted to use two-letter commandsw +andw -, but those don't work for the major mode. So using a nested transient bound towmeans at least the complete key sequences are the same.In my testing, adding watchers works, but removing fails with 403 every time. I can remove watchers on the web page, so I definitely have the correct permissions, and I'm pretty sure the code is correct. Let me know if you have any ideas!