Skip to content

#765 (Fixed): Include llama.cpp Vendored Libraries in Builds #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

caer
Copy link
Contributor

@caer caer commented Jul 8, 2025

This PR:

  1. Fixes publish failing #765 by updating the Cargo build to add llama.cpp's vendor libraries to the library path.
  2. Updates the CI checks for llama-cpp-rs to perform dry-runs of the cargo publish process, hopefully catching issues like this one before they're merged in the future.

@caer caer mentioned this pull request Jul 8, 2025
@MarcusDunn
Copy link
Contributor

thanks for the PR, this is great.

@MarcusDunn
Copy link
Contributor

MarcusDunn commented Jul 8, 2025

any ideas on the cause of the job failing? Because it's a new check, it may not be new behavior.

error: 1 files in the working directory contain changes that were not yet committed into git:

llama-cpp-sys-2/build.rs

to proceed despite this and include the uncommitted changes, pass the --allow-dirty flag
Error: Process completed with exit code 101.

@caer
Copy link
Contributor Author

caer commented Jul 8, 2025

Ah! The cargo fmt in CI was missing the --check flag; without that, it'll just run the formatter instead of flagging improperly formatted code. As a result, some code missing formatting was getting reformatted, thus the errors about a dirty workspace.

I pushed a second change to fix the cargo fmt, and also ran cargo fmt against the codebase (which should fix any formatting issues).

@MarcusDunn MarcusDunn merged commit b1dcf96 into utilityai:main Jul 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish failing
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy