Skip to content

feat(isIP): allow usage of options object #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 26, 2025

Conversation

pixelbucket-dev
Copy link
Contributor

@pixelbucket-dev pixelbucket-dev commented Oct 25, 2022

This PR implements steps 1 and 2 of #1874 for isIP and builds upon #2075.

This PR extracts tests for isIP into a separate test file ⇾ test/validators/isIP.test.js (inspired by #1793).

I have also added three more tests to guard against other possible values for version.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (54d330c) to head (0cace52).
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2089   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2324      2324           
  Branches       586       587    +1     
=========================================
  Hits          2324      2324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@braaar
Copy link
Contributor

braaar commented Oct 26, 2022

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

@pixelbucket-dev
Copy link
Contributor Author

pixelbucket-dev commented Oct 26, 2022

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

I've merged #2091 into this branch. But the diff won't be improved until #2091 is merged.

@braaar
Copy link
Contributor

braaar commented Oct 26, 2022

if we rebase/merge this with #2091, the diff will be much cleaner and easier to review

I've merged #2091 into this branch. But the diff won't be improved until #2091 is merged.

Ah, of course. And I suppose it's possible to set 2091 as the base branch, either.

@WikiRik
Copy link
Member

WikiRik commented Oct 26, 2022

Ah, of course. And I suppose it's possible to set 2091 as the base branch, either.

It is possible, but then it would be a PR in my fork and not this repo directly. So we'll have to deal with this workaround for now

@WikiRik WikiRik added the 🧹 needs-update For PRs that need to be updated before landing label Jan 30, 2023
@pixelbucket-dev
Copy link
Contributor Author

I think this should be good to go :).

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo the changes to the isAlpha tests?

@pixelbucket-dev
Copy link
Contributor Author

Can you undo the changes to the isAlpha tests?

Sorry, what exactly do you mean? I cannot see anything related to isAlpha in the diff view.

@WikiRik
Copy link
Member

WikiRik commented Feb 5, 2023

In the big test file you removed too much for this PR causing the codecov check to fail

@pixelbucket-dev
Copy link
Contributor Author

In the big test file you removed too much for this PR causing the codecov check to fail

Done :).

@pixelbucket-dev
Copy link
Contributor Author

Can this be re-reviewed?

@rubiin rubiin requested a review from WikiRik July 9, 2024 09:45
@WikiRik WikiRik removed the 🧹 needs-update For PRs that need to be updated before landing label Mar 26, 2025
@WikiRik WikiRik requested a review from rubiin March 26, 2025 20:45
@rubiin rubiin merged commit ac3d50a into validatorjs:master Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy