fix(lite/release): pass "duplex: 'half'" option to tarball request

If the body of a request is a stream, we could start receiving the response before the request has been fully sent (full duplex). However, Node does not support full duplex. Since other JS runtimes do support full duplex, Node now requires to pass "duplex: 'half'" for compatibility concerns with those JS runtimes. Spec: https://fetch.spec.whatwg.org/#ref-for-dom-requestinit-duplex WHATWG discussion: whatwg/fetch#1254 Node discussion: nodejs/node#46221
vatesfr · Apr 29, 2024 · e8ba8a9 · e8ba8a9
1 parent a321398
commit e8ba8a9
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/@xen-orchestra/lite/scripts/release.mjs b/@xen-orchestra/lite/scripts/release.mjs
@@ -112,6 +112,7 @@ const ghApiCall = async (path, method = 'GET', data) => {
 const ghApiUploadReleaseAsset = async (releaseId, assetName, file) => {
   const opts = {
     method: 'POST',
+    duplex: 'half',
     body: fs.createReadStream(file),
     headers: {
       Accept: 'application/vnd.github+json',