Auto-solito support #80968
Draft
Auto-solito support #80968
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
mischnic
reviewed
Jun 26, 2025
| @@ -196,6 +196,23 @@ async fn base_resolve_options( | |||
| environment.resolve_extensions().owned().await? | |||
| } else { | |||
| let mut ext = Vec::new(); | |||
|
|
|||
| if opt.enable_react_native_web_infix { | |||
There was a problem hiding this comment.
If you have opt.custom_extensions set, then this branch is never taken. Would you have expected that behavior (that you'd have to specify .web.* in there manually)?
There was a problem hiding this comment.
As of now, solito anticipates this behavior:
However, I wonder if the custom extensions should just come first and them merge with these?
mischnic
reviewed
Jun 26, 2025
…t.js into nandorojo/auto-solito
mischnic
reviewed
Jun 26, 2025
CodSpeed Performance ReportMerging #80968 will not alter performanceComparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.