Skip to content

fix: return Plugin[] instead of PluginOption[] #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 7, 2025
Merged

fix: return Plugin[] instead of PluginOption[] #537

merged 6 commits into from
Jul 7, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jul 6, 2025

Description

This makes plugin return types to be more specialized so that users can do this without type error:

 react({ babel: { plugins: ['babel-plugin-react-compiler'] } })
   .map(p => ({ ...p, applyToEnvironment: e => e.name === 'client' }))

@hi-ogawa hi-ogawa marked this pull request as ready for review July 6, 2025 09:20
@hi-ogawa hi-ogawa merged commit 11f56d6 into vitejs:main Jul 7, 2025
15 checks passed
sapphi-red added a commit that referenced this pull request Jul 18, 2025
@sapphi-red
chore: update changelog for #537
bbfd1b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@ArnaudBarre ArnaudBarre Awaiting requested review from ArnaudBarre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi-ogawa @sapphi-red
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy