-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[bugfix] fix megatron model merger #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ShareLer <ShareLe@163.com>
@ShareLer Thanks a lot for helping us to fix this, it helps a lot~ Could you briefly point out what causes vllm inference failure? Seems also involved a lot of refactorization. Is it caused by the missing parameters transferring? |
Signed-off-by: ShareLer <ShareLe@163.com>
Three main reasons:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add a test that reproduces the issue?
You can reproduce this problem very simply by using the CI script (like job 'e2e_ppo_trainer_megatron-qwen3' in e2e_ppo_trainer_megatron.yml) just change command option in merger: There were no problems in the previous CI test because different logics were used in the |
Checklist Before Starting
What does this PR do?
Fix megatron model merger.
High-Level Design
Specific Changes
API
Usage Example
# Add code snippet or script demonstrating how to use this
Test
Test with Qwen3-8B and Qwen2.5-7B.
Additional Info.
Checklist Before Submitting
[BREAKING]
to the PR title if it breaks any API.