Feature: welcome/upgrade page #140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, @AdrieanKhisbe I did not already had the time to have a look to this PR :( |
sipi
reviewed
Apr 8, 2019
There was a problem hiding this comment.
Hi @AdrieanKhisbe,
thanks for this PR, I think it's the good way to reach users of the "tootone version".
Everything seems fine to me, I only made two comments to better understand some of the parts.
So, now we have to edit the message! But, I suggest we keep it simple as :
Hello Org-mode users,
please note that tootone/org-mode has become vscode-org-mode/org-mode.
This version will probably no longer receive any update, to continue receiving
org-mode updates please uninstall tootone/org-mode and install
vscode-org-mode/org-mode instead.
Thank you.
We can possibly take the opportunity to add :
We take this opportunity to remind you that org-mode is built and maintained
by volunteers and that any help is welcome. If you like this extension and
have some time to devote to it, please visit the Github
repository: https://github.com/vscode-org-mode/vscode-org-mode
@sipi since it's good for you, I'll find some time to pursue this works, and incorporate your wordings :) |
|
@AdrieanKhisbe feel free to reword my wording ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new extension release, we need to find a way to reach our userbase to make them switch to the new publisher extension.
One way to do it, would be to publish a version that open a page explaining the user that he need to replace the extension to have latest features.
I start to dig how to implement that, (as bookmark, or gitlens do), and end up on vscode extensions samples.
So far, the current version will open the Upgrade page at start.
This is still beta and prototypal, focused on the mecanism rather than the message
Once working this would need to be backport on original extension, and a release with the original publisher should be made
We'll could later use that mecanism to publicize new features.
Feedback are more than welcome!!, I wanna know what you think about this :)
🦄