Skip to content

Builder::decorateAndCompileIfRequired returns wrong node #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lufriem opened this issue Mar 12, 2024 · 2 comments · Fixed by #1123
Closed

Builder::decorateAndCompileIfRequired returns wrong node #1122

lufriem opened this issue Mar 12, 2024 · 2 comments · Fixed by #1123

Comments

@lufriem
Copy link
Contributor

lufriem commented Mar 12, 2024

I think that's more of a latent bug, but it looks to me like Builder::decorateAndCompileIfRequired should, in case it's directed to create a cull node but cannot compute the bounds, return the 'subgraph' variable rather than its 'node' argument

So, basically, change line 252 from 'return node;' to 'return subgraph;'
lufriem added a commit to lufriem/VulkanSceneGraph that referenced this issue Mar 12, 2024
@lufriem
Corrected function return value. Fixes vsg-dev#1122
b840bf6
@robertosfield
Copy link
Collaborator

The fix looks appropriate, could you generate a PR for this fix, thanks.

I'm curious what is the type of GeomInfo.positions in your usage case?

@lufriem lufriem mentioned this issue Mar 13, 2024
Merged
9 tasks
@lufriem
Copy link
Contributor Author

lufriem commented Mar 13, 2024

Sorry I thought I did, still trying to figure out git(hub). I came across this while reading through the code, I don't actually have any test code/data to force the code to run this particular execution branch.

robertosfield added a commit that referenced this issue Mar 13, 2024
@robertosfield
Merge pull request #1123 from LeeRiva/lrdev
61516e1 
Corrected function return value. Fixes #1122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected function return value. Fixes #1122 lufriem/VulkanSceneGraph
2 participants
@robertosfield @lufriem
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy