fix(tailwind): regex for nonMediaQueryCSS #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #198
So, what do we have.
Several cases affected the styles rendering here, and their influence isn't obvious:
Let's consider what classes Tailwind generates based on the markup described in the test.
Now let's see how the classes for the nonMediaQueryCSS variable were processed before with the regex
/@media\s*\(.*\)\s*{\s*\.(.*)\s*{[\s\S]*}\s*}/gm
– https://regex101.com/r/op3l1l/1In this case, all styles are removed, which is an error, so such an innocent word "container" breaks the appearance.
The solution here is quite simple – correcting the regex to
/@media\s*\(.*?\)\s*{[^{}]*({[^{}]*}[^{}a]*)*}/gm
– https://regex101.com/r/i8FZZW/1P.S. Sorry, I actually had the solution for a long time, I just didn't have time to publish it 🌚