feat: more enhanced code blocks (follow up for #3235) #3258
+91
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
This is a follow up of #3235
During translating into Czech I originally found other two places where the filenames should be added into code blocks. When I switched to main vuejs/docs to implement those, I started to find more and ended up with this PR.
Proposed Solution
Hoist or infer filenames from codeblocks and add them as headers.
Sometimes, the code blocks change a bit, but I hope for the better.
Additional Information
I tried to went through all changes very carefully to verify them, including adjusting the hightlighted lines when necessary. I even think I find a few places, where it is not correct now on the live website. But as it is quite a large change, so I'll be happy to hear the feedback and I am ready to address any changes that might come necessary.