Skip to content

Incorrect type inference when you define slot element in v-for loop #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nkeyy0 opened this issue Dec 7, 2023 · 4 comments
Closed

Incorrect type inference when you define slot element in v-for loop #3787

nkeyy0 opened this issue Dec 7, 2023 · 4 comments
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first

Comments

@nkeyy0
Copy link

nkeyy0 commented Dec 7, 2023 •
edited
Loading

I'm trying to implement a table with dynamic slot names that are based on the column names, but I am faced with an issue with types in the v-for loop inside the template. For some reason the result type of the value is inferred as never, but if we do the same in the typescript we get a different type. Looks like it's an issue in the template type inferring.

Link to repro
@nkeyy0
Copy link
Author

nkeyy0 commented Dec 15, 2023 •
edited
Loading

It looks like the issue is because of as operator. When I use the as operator in the defineSlots mapped type it isn't asserted to type I want to and remains the key, not cell-${key}. How can I handle such a case?

@so1ve so1ve added bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first labels Dec 16, 2023
@so1ve
Copy link
Member

so1ve commented Dec 20, 2023

Seemed to be a typescript limitation: https://www.typescriptlang.org/play?#code/DYUwLgBAZg9jCEAuCAKFBDZBvCA3dwAriMgHaEC2ARiAE4DcEAvgJQQC8AfHjAJYAmbAD6oM2PAWLIARIVIBrUjADupaRBHTepCAAdaMAOa0QAZ1PrN-GKRDTGrDt1x9BG0Zgg58REhCpwoOikDmxcPAIsAFBRsDAoWFEAkD5SEADk6VGsQA

@nkeyy0
Copy link
Author

nkeyy0 commented Dec 24, 2023

Hmm, yeah. Looks like it is. I found an issue in the TS repo related to this behavior, but looks like it can be fixed by using generics. You can find more info in this PR. And I fixed my repro according to the suggested solution in the TS PR. You can see my fix here I'm just thinking about can it be fixed directly in the Vetur, or should it be applied in the user's code?

@csisy csisy mentioned this issue Jul 5, 2024
Closed
@kermanx
Copy link
Collaborator

kermanx commented Aug 13, 2024 •
edited
Loading

Assuming thatline 33 in the reproduction link has a missing [key]:

    <slot :name="`cell-${key}`" :value="tableRow[key]"></slot>
                                                ^^^^^

Then the problem is identical to this code.

Thus I think this is a TS limitation. We can't fix this on Vue's side.

@kermanx kermanx closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkeyy0 @so1ve @kermanx
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy