docs: added export size in FunctionInfo #2082
Conversation
| const info = computed(() => functions.find(i => i.name === props.fn)) | ||
| const format = (ts: number) => ago(-1, 'day') | ||
| const lastUpdated = useTimeAgo(new Date(info.value?.lastUpdated || 0)) | ||
| const link = computed(() => `/functions\#category=${encodeURIComponent(info.value.category)}`) | ||
|
|
||
| axios.get('/export-size.md').then(({ data }) => exportSizeMD.value = data) |
There was a problem hiding this comment.
We probably don't want to be fetching this data on each page. Ideally it would work like the other function metadata and be fetched during build time. Maybe instead we can include function size inside of @vueuse/metadata
There was a problem hiding this comment.
@wheatjs Thank you for pointing that out, I placed it in metadata.ts and used fs.readFileSync.
Would you happen to know why the document is not rendering?
I can see that console logging it in metadata shows me the correct data taken from export-size.md
here's the error
There was a problem hiding this comment.
I guess it's because code is being called in server and on client. There's no fs on client.
How do i put a if(process.client) ?
process here doesn't have server or client prop
haha I am not sure how to do this.
Please help :D
There was a problem hiding this comment.
I wanted to create a json file together with the export-size.md
but everytime i run pnpm size
I get this error.
There was a problem hiding this comment.
You need to run build first and then analyse the size
Hello @antfu, let me know if I still need to change something. |
|
Looks good. Thanks. |
Description
Added export size information inside FunctionInfo
What is the purpose of this pull request?