Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades Certifi and removes unused dependencies #25324

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Upgrades Certifi and removes unused dependencies #25324

merged 3 commits into from
Aug 28, 2024

Conversation

RamosFe
Copy link
Member

@RamosFe RamosFe commented Aug 22, 2024

Related issue
#24568

Description

  • Upgrade the certifi package to the version 2024.07.04 or higher.
  • Remove zipp and importlib-metadata dependencies.

@RamosFe RamosFe self-assigned this Aug 22, 2024
@RamosFe RamosFe linked an issue Aug 22, 2024 that may be closed by this pull request
Upgrade certifi package to version 2024.07.04 or higher and remove zipp and importlib-metadata #24568
Closed
4 tasks
@RamosFe RamosFe marked this pull request as ready for review August 22, 2024 13:49
@GGP1 GGP1 self-requested a review August 22, 2024 17:32
GGP1
GGP1 previously approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Authd integration tests failed with the error RuntimeError: The API was not started as expected. but the changes introduced shouldn't be related, the tests were executed successfully here.

fdalmaup
fdalmaup requested changes Aug 27, 2024
View reviewed changes
framework/requirements.txt Outdated Show resolved Hide resolved
src/Makefile Outdated Show resolved Hide resolved
fdalmaup
fdalmaup approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@fdalmaup fdalmaup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Commit signature remains to be applied.

Note

The failed checks are not related to the introduced changes

@RamosFe RamosFe force-pushed the change/24568-upgrade-certifi branch from b15c553 to 6bd01fd Compare August 27, 2024 14:11
Federico Ramos added 2 commits August 27, 2024 11:13
@RamosFe
Updated Makefile.
dda2baa 
Signed-off-by: Federico Ramos <framos@FramosMacbookAir.local>
Signed-off-by: Federico Ramos <federico.ramos@wazuh.com>
@RamosFe
Changed DEPS_VERSION and removed duplicated dependency.
6fee28e 
Signed-off-by: Federico Ramos <framos@FramosMacbookAir.local>
Signed-off-by: Federico Ramos <federico.ramos@wazuh.com>
@RamosFe RamosFe force-pushed the change/24568-upgrade-certifi branch from 6bd01fd to 6fee28e Compare August 27, 2024 14:13
@fdalmaup fdalmaup merged commit 46e2939 into 4.10.0 Aug 28, 2024
73 of 75 checks passed
@fdalmaup fdalmaup deleted the change/24568-upgrade-certifi branch August 28, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdalmaup fdalmaup fdalmaup approved these changes

@GGP1 GGP1 GGP1 left review comments

Assignees

@RamosFe RamosFe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade certifi package to version 2024.07.04 or higher and remove zipp and importlib-metadata
3 participants
@RamosFe @fdalmaup @GGP1
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy