PEP440 performance improvement #27320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
83a9d31 to
fabc89c
Compare
Testing 🟢We conducted a baseline stress test on the The comparison of both profiling outputs shows a significant performance improvement 🍋 It's the baseline output (🟨 graphs) processEvent zone
VersionMatch zone
Compare zone
The information used in this comparison, can be found here |
GabrielEValenzuela
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the PEP440 version parsing by replacing regex usage with a more efficient helper function
static std::vector<uint32_t> splitToNumbers(const std::string& str, const char delimiter). This change enhances performance and simplifies the implementation by directly splitting the version string into numeric components.