[text-box-trim] Rename text-box-edge values
#47598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db4924f to
bec938b
Compare
This patch renames `text-box-edge` values from: ``` text-box-edge: leading | <text-edge> ``` to: ``` text-box-edge: auto | <text-edge> ``` Note the `<text-edge>` definition is unchanged. ``` <text-edge> = [ text | cap | ex ] [ text | alphabetic ]? ``` as per the resolution at: w3c/csswg-drafts#10675 (comment) and the new spec at: https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge As per the new spec, the new `auto` value is identical to `text` when the `line-fit-edge` property is initial. The functionality the `leading` value provided is removed. Bug: 358204934, 40254880 Change-Id: I738058cc79b5525b2cbb151b5765f65363b44e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776349 Reviewed-by: Lingqi Chi <lingqi@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1341434}
bec938b to
cfa9d9b
Compare
wpt-pr-bot
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames
text-box-edgevalues from:to:
Note the
\<text-edge>definition is unchanged.as per the resolution at:
w3c/csswg-drafts#10675 (comment)
and the new spec at:
https://drafts.csswg.org/css-inline-3/#propdef-text-box-edge
As per the new spec, the new
autovalue is identical totextwhen theline-fit-edgeproperty is initial.The functionality the
leadingvalue provided is removed.Bug: 358204934, 40254880
Change-Id: I738058cc79b5525b2cbb151b5765f65363b44e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776349
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1341434}