Skip to content

Types for client #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2025
Merged

Types for client #5541

merged 5 commits into from
Jul 17, 2025

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Existing

Motivation / Use-Case

types for client, because we use babel and webpack doesn't provide types for runtime, currently skip them

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.30%. Comparing base (37b033d) to head (a8e90c2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
client-src/progress.js 0.00% 11 Missing ⚠️
client-src/socket.js 0.00% 3 Missing ⚠️
client-src/index.js 83.33% 1 Missing ⚠️
client-src/overlay.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5541      +/-   ##
==========================================
- Coverage   83.43%   83.30%   -0.14%     
==========================================
  Files          13       13              
  Lines        2035     2037       +2     
  Branches      751      750       -1     
==========================================
- Hits         1698     1697       -1     
- Misses        303      306       +3     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait alexander-akait merged commit 78daef9 into master Jul 17, 2025
52 of 102 checks passed
@alexander-akait alexander-akait deleted the types-for-client branch July 17, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy