Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a limited size buffer for streaming upload in HTTP request. #1204

Merged
merged 12 commits into from
Apr 20, 2021
Merged

Add a limited size buffer for streaming upload in HTTP request. #1204

merged 12 commits into from
Apr 20, 2021

Conversation

yoichio
Copy link
Contributor

@yoichio yoichio commented Mar 30, 2021 •
edited by annevk
Loading

(See WHATWG Working Mode: Changes for more details.)

This fixes #538.

Preview | Diff

@yoichio
Copy link
Contributor Author

yoichio commented Apr 5, 2021

Ping?

yutakahirano
yutakahirano reviewed Apr 7, 2021
View reviewed changes
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Show resolved Hide resolved
yutakahirano
yutakahirano reviewed Apr 12, 2021
View reviewed changes
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
@yutakahirano
Copy link
Member

LGTM. Can you update the PR title?

@annevk: do you want to take a look at this?

@yoichio yoichio changed the title Limit the network stack replay cache on uploading if body is stream. Add a limited size buffer for streaming upload in HTTP request. Apr 13, 2021
@annevk
Copy link
Member

annevk commented Apr 13, 2021

I'm concerned about this not having an upper bound as I wrote in #538 (comment). I think there should be an upper bound.

annevk
annevk reviewed Apr 13, 2021
View reviewed changes
fetch.bs Outdated Show resolved Hide resolved
annevk
annevk reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good modulo a couple tiny nits.

fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
yoichio and others added 4 commits April 15, 2021 15:16
@yoichio @annevk
Update fetch.bs
89cb459 
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@yoichio @annevk
Update fetch.bs
a8d1a09 
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
fix nits
ec597c0
@annevk
fix additional nits myself
01ccdf4
@annevk annevk mentioned this pull request Apr 15, 2021
Closed
@annevk
Copy link
Member

annevk commented Apr 15, 2021

We probably need to say explicitly that a network error is returned if you need to resend and the buffer became useless?

Also, let's file an issue against web-platform-tests outlining what would be needed to test this.

Other than that we're good I think.

@yoichio
Copy link
Contributor Author

yoichio commented Apr 19, 2021

Done both.

annevk
annevk approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some final tweaks, does this still look good to you @yoichio?

@yoichio
Copy link
Contributor Author

yoichio commented Apr 20, 2021

LGTM.

@annevk annevk merged commit 6453947 into whatwg:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddragana ddragana ddragana left review comments

@yutakahirano yutakahirano yutakahirano left review comments

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request body streams that cannot be retried
4 participants
@yoichio @yutakahirano @annevk @ddragana
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy