Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ARM_TARGET option() to selection-list #2394

Closed
wants to merge 1 commit into from
Closed

Convert ARM_TARGET option() to selection-list #2394

wants to merge 1 commit into from

Conversation

Spudz76
Copy link
Contributor

@Spudz76 Spudz76 commented May 20, 2021

CMake option() shortcut for cached entries is intended only of ON/OFF (boolean) items.

Convert to string selection-list which works smooth in ccmake/cmake-gui

May reduce having to force with -DARM_TARGET=8 to override the boolean nature of the option when possibly re-coerced to ON or OFF during config or generation steps. Did not observe such a bug, but there are definitely some sort of bugs around that option working as intended.

@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 94493f9 to 8e85e1a Compare May 20, 2021 03:33
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 8e85e1a to 2d488c2 Compare May 27, 2021 09:20
@Spudz76
Copy link
Contributor Author

Spudz76 commented May 27, 2021

Fixed up logic, tested on ARMv8 debian VM.

@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 5 times, most recently from 2557f85 to 2735420 Compare September 22, 2021 15:40
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from a4e6092 to 4594eff Compare October 5, 2021 19:52
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from 3b9d7e6 to a4caf3d Compare October 13, 2021 01:07
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from 3bc2dfb to 0944aee Compare October 25, 2021 21:57
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from eb0fba3 to 75049a8 Compare November 2, 2021 12:21
@Spudz76 Spudz76 mentioned this pull request Nov 2, 2021
Closed
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 75049a8 to 80cba83 Compare November 11, 2021 11:38
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 7 times, most recently from 1798d90 to 835cdb4 Compare December 3, 2021 19:27
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from c03b33a to 8896d33 Compare December 19, 2021 18:12
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 8896d33 to c9cb0a1 Compare December 30, 2021 16:36
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from c9cb0a1 to d821eca Compare January 18, 2022 03:18
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from d821eca to 04b107e Compare January 31, 2022 19:26
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 505bcfc to 944472b Compare May 6, 2022 00:51
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from d1edca6 to 10904dd Compare May 21, 2022 11:43
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 10904dd to f92ac68 Compare June 12, 2022 20:55
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from c51d113 to 9c66b17 Compare June 28, 2022 04:12
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 9c66b17 to 7ca33a3 Compare July 3, 2022 16:11
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from 5ea8314 to 9e510c2 Compare August 26, 2022 00:20
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 4 times, most recently from 0832345 to b2e07a3 Compare September 22, 2022 03:35
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from 27e486e to 2abfa7e Compare October 1, 2022 17:35
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 2abfa7e to 0ba9dc6 Compare October 11, 2022 02:34
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from 4211b91 to 45a6c84 Compare October 24, 2022 12:04
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 45a6c84 to 156fea8 Compare November 19, 2022 20:52
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 156fea8 to 5b4fb0d Compare December 17, 2022 16:05
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch 2 times, most recently from 255d9c5 to 853969b Compare March 7, 2023 21:42
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 853969b to 6cc62fb Compare April 1, 2023 21:40
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 6cc62fb to 49b18d4 Compare May 23, 2023 01:36
@Spudz76 Spudz76 force-pushed the dev-fixCmakeARMTARGET branch from 49b18d4 to 8927f24 Compare May 23, 2023 22:49
@xmrig
Copy link
Owner

xmrig commented Jun 5, 2023

Misuse of option fixed by 6dbd46a
Thank you.

@xmrig xmrig closed this Jun 5, 2023
@xmrig xmrig added this to the v6 milestone Jun 5, 2023
@xmrig xmrig added the bug label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v6
Development

Successfully merging this pull request may close these issues.
2 participants
@Spudz76 @xmrig
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy