refactor: Centralize query condition building in QueryConditionBuilder.
#48
Conversation
|
Warning Rate limit exceeded@terabytesoftw has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NestedSetsBehavior
participant QueryConditionBuilder
User->>NestedSetsBehavior: Perform tree operation (e.g., find children, move node)
NestedSetsBehavior->>QueryConditionBuilder: Build query condition via static method
QueryConditionBuilder-->>NestedSetsBehavior: Return condition array
NestedSetsBehavior->>NestedSetsBehavior: Use cached attribute values
NestedSetsBehavior-->>User: Complete operation
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 102 131 +29
===========================================
Files 3 4 +1
Lines 504 528 +24
===========================================
+ Hits 504 528 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/NestedSetsBehavior.php(29 hunks)src/QueryConditionBuilder.php(1 hunks)tests/NestedSetsBehaviorTest.php(0 hunks)tests/support/stub/ExtendableNestedSetsBehavior.php(0 hunks)
💤 Files with no reviewable changes (2)
- tests/support/stub/ExtendableNestedSetsBehavior.php
- tests/NestedSetsBehaviorTest.php
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: terabytesoftw
PR: yii2-extensions/nested-sets-behavior#13
File: src/NestedSetsBehavior.php:145-145
Timestamp: 2025-06-29T11:22:41.889Z
Learning: The user terabytesoftw prefers to keep PRs focused and small, implementing enhancements in separate dedicated PRs rather than bundling multiple changes together.
🪛 GitHub Actions: ecs
src/NestedSetsBehavior.php
[warning] 502-502: PhpCsFixer: Missing trailing comma in multiline array or argument list. Run 'vendor/bin/ecs check --fix' to apply the fix.
[warning] 929-929: PhpCsFixer: Missing trailing comma in multiline array or argument list. Run 'vendor/bin/ecs check --fix' to apply the fix.
[warning] 1146-1146: PhpCsFixer: Missing trailing comma in multiline array or argument list. Run 'vendor/bin/ecs check --fix' to apply the fix.
[warning] 1165-1165: PhpCsFixer: Missing trailing comma in multiline array or argument list. Run 'vendor/bin/ecs check --fix' to apply the fix.
[warning] 1186-1186: PhpCsFixer: Missing trailing comma in multiline array or argument list. Run 'vendor/bin/ecs check --fix' to apply the fix.
[warning] 1438-1438: PhpCsFixer: Missing trailing comma in multiline array or argument list. Run 'vendor/bin/ecs check --fix' to apply the fix.
🪛 GitHub Check: phpstan / PHP 8.4-ubuntu-latest
src/QueryConditionBuilder.php
[failure] 428-428:
Method yii2\extensions\nestedsets\QueryConditionBuilder::createSubtreeMoveCondition() return type has no value type specified in iterable type array.
🪛 GitHub Check: mutation / PHP 8.4-ubuntu-latest
src/QueryConditionBuilder.php
[failure] 428-428:
Method yii2\extensions\nestedsets\QueryConditionBuilder::createSubtreeMoveCondition() return type has no value type specified in iterable type array.
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: phpunit-compatibility / PHP 8.4-windows-latest
- GitHub Check: phpunit-compatibility / PHP 8.3-windows-latest
- GitHub Check: phpunit-compatibility / PHP 8.1-windows-latest
- GitHub Check: phpunit-compatibility / PHP 8.3-ubuntu-latest
- GitHub Check: phpunit-compatibility / PHP 8.2-windows-latest
- GitHub Check: phpunit / PHP 8.4-windows-latest
- GitHub Check: phpunit / PHP 8.2-windows-latest
- GitHub Check: phpunit / PHP 8.1-windows-latest
- GitHub Check: mutation / PHP 8.4-ubuntu-latest
- GitHub Check: phpunit / PHP 8.4-ubuntu-latest
- GitHub Check: phpunit / PHP 8.3-windows-latest
- GitHub Check: phpunit-compatibility / PHP 8.4-ubuntu-latest
- GitHub Check: phpstan / PHP 8.4-ubuntu-latest
🔇 Additional comments (5)
src/NestedSetsBehavior.php (4)
133-147: Good addition of caching for performance optimizationThe introduction of cached values for frequently accessed attributes (depth, left, right) is a solid performance improvement that reduces repeated database attribute lookups.
225-225: Good modernization of exception messagesUsing
::classsyntax instead ofget_class()is cleaner and more idiomatic in modern PHP.Also applies to: 351-351, 406-406
622-625: Good validation additionAdding the check to prevent inserting after a new record is a good defensive programming practice that prevents potential runtime errors.
1336-1343: Well-implemented caching gettersThe getter methods follow a consistent lazy-loading pattern that ensures values are fetched only once and cached for subsequent access. This is a clean implementation that improves performance.
Also applies to: 1345-1352, 1378-1385
src/QueryConditionBuilder.php (1)
1-31: Well-structured utility class for query condition buildingThe
QueryConditionBuilderclass is well-designed with clear documentation and appropriate use of thefinalkeyword for a utility class. The static methods are suitable for this type of functionality.
…tion()` method in `QueryConditionBuilder`.
…ndition logic and removing redundant checks.
…ing nodes correctly.
There was a problem hiding this comment.
Pull Request Overview
Centralizes query condition construction by introducing a QueryConditionBuilder utility and refactors NestedSetsBehavior to leverage it, removing redundant methods and stubs.
Key changes:
- Added
QueryConditionBuilderwith static methods for all nested-set query conditions. - Refactored
NestedSetsBehaviorto replace inline condition arrays with builder calls and added caching for boundary attributes. - Removed the deprecated
applyTreeAttributeConditionstub and related tests.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/support/stub/ExtendableNestedSetsBehavior.php | Removed deprecated exposedApplyTreeAttributeCondition stub |
| tests/NestedSetsBehaviorTest.php | Removed tests for deprecated behavior and legacy exception path |
| src/QueryConditionBuilder.php | New utility class for standardized nested-set query condition building |
| src/NestedSetsBehavior.php | Refactored to use QueryConditionBuilder, removed inline conditions, added attribute caching |
Comments suppressed due to low confidence (1)
src/QueryConditionBuilder.php:1
- Consider adding dedicated unit tests for each
QueryConditionBuildermethod to ensure comprehensive coverage of all new condition-building utilities.
<?php
Summary by CodeRabbit
New Features
Improvements
Refactor
Tests