Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add floating recipient bar (FRB) to top of central column. #340

Closed
2 of 3 tasks
sumanthvrao opened this issue Apr 5, 2019 · 3 comments
Closed
2 of 3 tasks

Add floating recipient bar (FRB) to top of central column. #340

sumanthvrao opened this issue Apr 5, 2019 · 3 comments
Assignees
@sumanthvrao
Labels
in progress

Comments

@sumanthvrao
Copy link
Member

sumanthvrao commented Apr 5, 2019 •
edited
Loading

(quoted from discussion)
The top 'recipient' area in ZT in the middle column shows the recipient (and search string text) of the current message. If you are narrowed to a specific topic, or private messages, or messages with specific people, then it doesn't distinguish that. If you press z repeatedly, the shown messages should currently update, but not the top recipient area.
A better manner to represent the narrow would be :

  • v0 - [narrow/search] + [message-narrow] on separate lines
  • v1 -
search: 
Floating Recipient bar:
  • v2 - stream/people being highlighted

Related Discussion :
@sumanthvrao
Copy link
Member Author

@zulipbot claim

@sumanthvrao sumanthvrao mentioned this issue Apr 16, 2019
Closed
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 16, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
b4657d1 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 20, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
242102d 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 20, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
53e71a1 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 20, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
4b5e67f 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 23, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
f47fbd8 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 27, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
d9b40ba 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Tests added.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 27, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
1790607 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Tests added.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 27, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
6982cc1 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Tests added.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 28, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
dffb476 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Tests added.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue Apr 30, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
cdac3e6 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Tests added.

Fixes: zulip#340
@zulipbot
Copy link
Member

Hello @sumanthvrao, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue May 11, 2019
@sumanthvrao
views/boxes: Update top_bar text when narrow or focus change.
212904c 
We update the narrow and focus in top_header_bar
and top_search_bar when it changes.

Tests added.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue May 19, 2019
@sumanthvrao
views: Update text in header bars when narrow or focus changes.
c63429b 
Handles the logic of updating the narrow and focus in
both top_header_bar and top_search_bar when either
(narrow/focus) change.

Tests added.

Fixes: zulip#340
@sumanthvrao
Copy link
Member Author

@zulipbot add "UI"

sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue May 31, 2019
@sumanthvrao
views/boxes: Update 'conversation focus' based on current narrow.
93cdd79 
* Introduces 'conversation focus' to better describe
  the current narrow.
* Handles the logic of updating the narrow and focus, in
  both recipient_bar and search_bar when either
  (narrow/focus) change.

Tests added.

Fixes: zulip#340
sumanthvrao added a commit to sumanthvrao/zulip-terminal that referenced this issue May 31, 2019
@sumanthvrao
views/boxes: Update 'conversation focus' based on current narrow.
e19c541 
* Introduces 'conversation focus' to better describe
  the current narrow.
* Handles the logic of updating the narrow and focus, in
  both recipient_bar and search_bar when either
  (narrow/focus) change.

Tests added.

Fixes: zulip#340
neiljp pushed a commit to neiljp/zulip-terminal that referenced this issue Jun 3, 2019
@sumanthvrao @neiljp
views/boxes: Update 'conversation focus' based on current narrow.
a5d31c0 
* Introduces 'conversation focus' to better describe
  the current narrow.
* Handles the logic of updating the narrow and focus, in
  both recipient_bar and search_bar when either
  (narrow/focus) change.

Tests added.

Fixes: zulip#340
@neiljp neiljp closed this as completed in 674f8ab Jun 4, 2019
amanagr pushed a commit to amanagr/zulip-terminal that referenced this issue Jun 13, 2019
@sumanthvrao @amanagr
views/boxes: Update 'conversation focus' based on current narrow.
f4fdcd6 
* Introduces 'conversation focus' to better describe
  the current narrow.
* Handles the logic of updating the narrow and focus, in
  both recipient_bar and search_bar when either
  (narrow/focus) change.

Tests added.

Fixes: zulip#340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumanthvrao sumanthvrao

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve recipient bar layout and design sumanthvrao/zulip-terminal
2 participants
@zulipbot @sumanthvrao
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy