@Dishti-Oberai your PR should only contain the changes that are required. Please read https://zulip.readthedocs.io/en/latest/contributing/index.html

Thanks @amanagr , I'll take care from next time.

@Dishti-Oberai I recently pushed a commit to main excluding the .idea files, so I just pushed to your branch here without those files, which makes it a little easier to read.

Before I pushed, I rebased against main to get those changes in the branch, which has some side-effects for implementation, since we recently added a new style (msg_heading) which will now need to be present in the theme you're adding too.

You could fetch from the updated PR, or fetch main and rebase your local branch against that in future - the latter being a good idea in general.

Before pushing, I couldn't test it directly since I had some trouble running it - an error regarding DARK_RED. I still get it on this branch now.

In terms of implementation, I think this would be clearer and simpler if you could split the change into two commits:

• one preparing for adding the new theme by refactoring the code so the behavior is very similar but implemented differently (eg. extracting common gruvbox colors)
• the second simply adding the new theme file

Let us know here or in the stream if you need any extra feedback!
(I've not looked at the test issues; can you see what's going wrong?)

Thank you for the review @neiljp , I'll do the needful

@neiljp
I have figured out why was DARK_RED prompting an error and have resolved it as well.
I want to gain some insight into the steps of implementation that you have mentioned.... should I now make 2 commits into this PR only (according to the aforementioned steps) or do I need to make a new PR for the same? Please guide.

Hello @Dishti-Oberai, it seems like you have referenced #1133 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #1133..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to Zulip!

@Dishti-Oberai Thanks for getting this done; I did a final review before merging just now 🎉

we can look at the reordering and generally tidying the gruvbox styling further if you'd like, as we discussed. I removed the change to gruvbox_dark since it seems OK as it is for now, and also the THEME_ALIASES change, since they are old theme names that we're still keeping working (#648).

Note that I also adjusted the commit text style to match the style we use, which is why I suggested installing gitlint previously.