Check validity of recipients on manual modification #738
Conversation
There was a problem hiding this comment.
@kaustubh-nair Thanks for this addition. I tested this manually and it works well. One suggestion I felt would be useful is if we indicated which of the emails (in case of huddle, etc) is invalid. So example the footer would display Invalid recipients - abc@zulip.com. For streams and single-user PM although this wouldn't add any extra meaning, its a more detailed error message to display.
What do you think?
| @@ -654,6 +654,16 @@ def _handle_typing_event(self, event: Event) -> None: | |||
| else: | |||
There was a problem hiding this comment.
Typo: I think the commit description should be
currently no check in place
There was a problem hiding this comment.
No space before bracket currently.
bb94736 to
826853e
Compare
|
@sumanthvrao thanks for the review! |
There was a problem hiding this comment.
@kaustubh-nair This works well - just a few minor points and I'd love to have this merged 👍
| @@ -654,6 +654,16 @@ def _handle_typing_event(self, event: Event) -> None: | |||
| else: | |||
There was a problem hiding this comment.
No space before bracket currently.
Users can manually alter the recipients/stream name, but currently, there is no check in place to ensure validity of these modifications. This commit checks the recipients everytime the user presses TAB on the boxes (stream name and recipients for private messages), and displays an error message in the footer if a recipient is invalid.
826853e to
7c308e0
Compare
|
@neiljp Thanks for the review! |
|
@kaustubh-nair Thanks for the updates and adding this feature! 👍 I'm going to merge this now, but I think we'll want to ensure that we get connected issues resolved in the near future if we can, or open issues for them. Things I'm thinking about off the top of my head are trailing commas and other characters (which still cause potentially confusing messages), and that the only way to resolve the 'invalid' case is by entering valid data - which the user may not know (so if they are mid-compose, then they may potentially have to |
Users can manually alter the recipients/stream name, but there is
currently to check in place to ensure validity of these modifications.
This commit checks the recipients everytime the user presses TAB on the
boxes (stream name and recipients for private messages).