fix crash when the source image is less than 3 pixels width/height #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for that crash to happen you would need to call it with |
|
No, it's not the threshold, it's the |
|
Maybe I understand now: your image is e.g. 500x1 pixels big? So one side is >threshold, the other <3? |
|
Suppose the threshold is 500, a 600x1 image would cause the crash without the fix. |
|
Yes. |
|
Thanks for the patch and the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the last witdh or height of the last layer is less than
N, it would create another layer with empty image and cause crash.